fix: handle no-op case-W-22406465#156
Merged
Merged
Conversation
jfeingold35
reviewed
May 11, 2026
| run: | | ||
| cd docs | ||
| git add . | ||
| git diff --cached --quiet && echo "No docs changes to publish" && exit 0 |
Contributor
There was a problem hiding this comment.
When there are changes, git diff --quiet will return a non-zero exit code, and I believe the way it's done here will crash the job. I think you'll need to combine this line with the next one to create something more like this instead:
git diff --cached --quiet || git commit -m "docs: publishing gh-pages [skip ci]" --no-verify
jfeingold35
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
git diff --cached --quietcheck before the commit. If nothing is staged, the step exits 0 cleanly and skip the commit and push.@W-22406465@